[mypyc] fix: UnboundLocalError incorrectly raised as AttributeError #20085
+49
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes mypyc/mypyc#1151 I'm not entirely sure what the difference is between emit_attribute_error and the code block that I edited I'm not sure if we need to update both cases, but I know we do need to handle it in this one
BobTheBuidler
commented
Oct 18, 2025
| attr.removeprefix(GENERATOR_ATTRIBUTE_PREFIX), | ||
| op.traceback_entry[1], | ||
| globals_static, | ||
| if class_ir.is_generated: |
Contributor
Author
There was a problem hiding this comment.
I put this here so it will do its job in any place emit_attribute_error might be used in the future, it didn't seem appropriate to add another helper but this doesn't really seem appropriate either
JukkaL
reviewed
Nov 13, 2025
| ) | ||
| ) | ||
| var_name = op.attr.removeprefix(GENERATOR_ATTRIBUTE_PREFIX) | ||
| if cl.is_generated: |
Collaborator
There was a problem hiding this comment.
A better approach would be to add a new flag to ClassIR such as is_environment that is set when the attributes represent local variables. This way if we add a new kind of generated class that doesn't represent locals, AttributeError will be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes mypyc/mypyc#1151